[LWN Logo]

Subject: Re: [PATCH] f_op->poll() without lock_kernel()
To:	manfreds@colorfullife.com (Manfred Spraul)
Date:	Fri, 21 Apr 2000 20:42:54 +0100 (BST)
From:	Alan Cox <alan@lxorguk.ukuu.org.uk>

> kumon@flab.fujitsu.co.jp noticed that select() caused a high contention
> for the kernel lock, so here is a patch that removes lock_kernel() from
> poll().
> 
> I tested that patch with 2.3.99-pre5.

This is not a good idea if we are trying to stabilise 2.4. I for one am
not in favour of making further changes now that require we reaudit every
damned block and char device again. Which btw is what your change requires.
Do this after 2.4. Yes its a contention issue, no its not as trivial as
your little fix implies


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/