[LWN Logo]
[Timeline]
Date:         Mon, 10 Jul 2000 00:28:15 -0700
From: Kris Kennaway <kris@FREEBSD.ORG>
Subject:      opieftpd setproctitle() patches
To: BUGTRAQ@SECURITYFOCUS.COM

Since the OPIE software doesn't appear to be actively maintained any more,
I thought I'd post the (trivial) patches to the recent setproctitle()
thing.

Actually this is against the version from the FreeBSD source tree, so the
offsets may be a bit different. We don't actually compile this code in
FreeBSD, it's just along for the ride under /usr/src/contrib with the
other OPIE stuff that we do use.

Kris

Index: opieftpd.c
===================================================================
RCS file: /home/ncvs/src/contrib/opie/opieftpd.c,v
retrieving revision 1.3
diff -u -r1.3 opieftpd.c
--- opieftpd.c	2000/04/10 11:18:47	1.3
+++ opieftpd.c	2000/07/10 07:23:02
@@ -633,7 +633,7 @@
 #if DOTITLE
     snprintf(proctitle, sizeof(proctitle), "%s: anonymous/%s", remotehost,
 	passwd);
-    setproctitle(proctitle);
+    setproctitle("%s", proctitle);
 #endif	/* DOTITLE */
     syslog(LOG_NOTICE, "ANONYMOUS FTP login from %s with ID %s",
             remotehost, passwd);
@@ -644,7 +644,7 @@

 #if DOTITLE
     snprintf(proctitle, sizeof(proctitle), "%s: %s", remotehost, pw->pw_name);
-    setproctitle(proctitle);
+    setproctitle("%s", proctitle);
 #endif	/* DOTITLE */
     syslog(LOG_INFO, "FTP login from %s with user name %s", remotehost, pw->pw_name);
   }
@@ -1262,7 +1262,7 @@
   remotehost[sizeof(remotehost) - 1] = '\0';
 #if DOTITLE
   snprintf(proctitle, sizeof(proctitle), "%s: connected", remotehost);
-  setproctitle(proctitle);
+  setproctitle("%s", proctitle);
 #endif	/* DOTITLE */

   t = time((time_t *) 0);

--
In God we Trust -- all others must submit an X.509 certificate.
    -- Charles Forsythe <forsythe@alum.mit.edu>