From:	Keith Owens <kaos@ocs.com.au>
To:	linux-kernel@vger.kernel.org
Subject: Re: Announce: modutils 2.3.23 is available 
Date:	Wed, 20 Dec 2000 11:43:13 +1100

modutils 2.3.23 has a bug with empty MODULE_GENERIC_STRING entries,
depmod loops.

Index: 23.11/depmod/depmod.c
--- 23.11/depmod/depmod.c Sun, 17 Dec 2000 10:18:04 +1100 kaos (modutils-2.3/b/43_depmod.c 1.39 644)
+++ 23.11(w)/depmod/depmod.c Wed, 20 Dec 2000 08:13:18 +1100 kaos (modutils-2.3/b/43_depmod.c 1.39 644)
@@ -388,9 +388,8 @@ static void extract_generic_string(struc
 			error("unterminated generic string '%*s'", p - s, s);
 			break;
 		}
-		if (p == s)		/* empty string? */
+		if (p++ == s)		/* empty string? */
 			continue;
-		p++;	/* step over NUL */
 		mod->generic_string = xrealloc(mod->generic_string, ++(mod->n_generic_string)*sizeof(*(mod->generic_string)));
 		latest = mod->generic_string + mod->n_generic_string-1;
 		*latest = xstrdup(s);

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/